Commit 5c4663ed authored by Smita Koralahalli's avatar Smita Koralahalli Committed by Borislav Petkov (AMD)
Browse files

x86/mce: Handle AMD threshold interrupt storms 



Extend the logic of handling CMCI storms to AMD threshold interrupts.

Rely on the similar approach as of Intel's CMCI to mitigate storms per CPU and
per bank. But, unlike CMCI, do not set thresholds and reduce interrupt rate on
a storm. Rather, disable the interrupt on the corresponding CPU and bank.
Re-enable back the interrupts if enough consecutive polls of the bank show no
corrected errors (30, as programmed by Intel).

Turning off the threshold interrupts would be a better solution on AMD systems
as other error severities will still be handled even if the threshold
interrupts are disabled.

  [ Tony: Small tweak because mce_handle_storm() isn't a pointer now ]
  [ Yazen: Rebase and simplify ]
  [ Avadhut: Remove check to not clear bank's bit in mce_poll_banks and fix
    checkpatch warnings. ]

Signed-off-by: default avatarSmita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Signed-off-by: default avatarTony Luck <tony.luck@intel.com>
Signed-off-by: default avatarYazen Ghannam <yazen.ghannam@amd.com>
Signed-off-by: default avatarAvadhut Naik <avadhut.naik@amd.com>
Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
Link: https://patch.msgid.link/20251121190542.2447913-3-avadhut.naik@amd.com
parent d7ac083f

arch/x86/kernel/cpu/mce/amd.c

+5 −0
Original line number Diff line number Diff line
@@ -852,6 +852,11 @@ static void amd_deferred_error_interrupt(void) 
	machine_check_poll(MCP_TIMESTAMP, &this_cpu_ptr(&mce_amd_data)->dfr_intr_banks);

}



void mce_amd_handle_storm(unsigned int bank, bool on)

{

	threshold_restart_bank(bank, on);

}



static void amd_reset_thr_limit(unsigned int bank)

{

	threshold_restart_bank(bank, true);

arch/x86/kernel/cpu/mce/internal.h

+2 −0
Original line number Diff line number Diff line
@@ -269,6 +269,7 @@ void mce_prep_record_per_cpu(unsigned int cpu, struct mce *m); 
#ifdef CONFIG_X86_MCE_AMD

void mce_threshold_create_device(unsigned int cpu);

void mce_threshold_remove_device(unsigned int cpu);

void mce_amd_handle_storm(unsigned int bank, bool on);

extern bool amd_filter_mce(struct mce *m);

bool amd_mce_usable_address(struct mce *m);

void amd_clear_bank(struct mce *m);
@@ -301,6 +302,7 @@ void smca_bsp_init(void); 
#else

static inline void mce_threshold_create_device(unsigned int cpu)	{ }

static inline void mce_threshold_remove_device(unsigned int cpu)	{ }

static inline void mce_amd_handle_storm(unsigned int bank, bool on)	{ }

static inline bool amd_filter_mce(struct mce *m) { return false; }

static inline bool amd_mce_usable_address(struct mce *m) { return false; }

static inline void amd_clear_bank(struct mce *m) { }

arch/x86/kernel/cpu/mce/threshold.c

+3 −0
Original line number Diff line number Diff line
@@ -76,6 +76,9 @@ static void mce_handle_storm(unsigned int bank, bool on) 
	case X86_VENDOR_INTEL:

		mce_intel_handle_storm(bank, on);

		break;

	case X86_VENDOR_AMD:

		mce_amd_handle_storm(bank, on);

		break;

	}

}