Unverified Commit 5c4e15e6 authored by Muhammad Usama Anjum's avatar Muhammad Usama Anjum Committed by Mark Brown
Browse files

ASoC: mediatek: mt8365: check validity before usage of i2s_data 



There may be a case where i2s_data may not get initialized by the for
loop which will cause the kernel crash. Initialize the i2s_data to NULL
and abort execute if it isn't found.

Fixes: 402bbb13 ("ASoC: mediatek: mt8365: Add I2S DAI support")
Signed-off-by: default avatarMuhammad Usama Anjum <usama.anjum@collabora.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patch.msgid.link/20240911111317.4072349-1-usama.anjum@collabora.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 0b0aa67b

sound/soc/mediatek/mt8365/mt8365-dai-i2s.c

+4 −1
Original line number Diff line number Diff line
@@ -465,13 +465,16 @@ void mt8365_afe_set_i2s_out_enable(struct mtk_base_afe *afe, bool enable) 
	int i;

	unsigned long flags;

	struct mt8365_afe_private *afe_priv = afe->platform_priv;

	struct mtk_afe_i2s_priv *i2s_data;

	struct mtk_afe_i2s_priv *i2s_data = NULL;



	for (i = 0; i < DAI_I2S_NUM; i++) {

		if (mt8365_i2s_priv[i].adda_link)

			i2s_data = afe_priv->dai_priv[mt8365_i2s_priv[i].id];

	}



	if (!i2s_data)

		return;



	spin_lock_irqsave(&afe_priv->afe_ctrl_lock, flags);



	if (enable) {