Commit 5c4e79e2 authored by Jan Beulich's avatar Jan Beulich Committed by Juergen Gross
Browse files

xenfs/xensyms: respect hypervisor's "next" indication 



The interface specifies the symnum field as an input and output; the
hypervisor sets it to the next sequential symbol's index. xensyms_next()
incrementing the position explicitly (and xensyms_next_sym()
decrementing it to "rewind") is only correct as long as the sequence of
symbol indexes is non-sparse. Use the hypervisor-supplied value instead
to update the position in xensyms_next(), and use the saved incoming
index in xensyms_next_sym().

Cc: stable@kernel.org
Fixes: a11f4f0a ("xen: xensyms support")
Signed-off-by: default avatarJan Beulich <jbeulich@suse.com>
Reviewed-by: default avatarJuergen Gross <jgross@suse.com>
Message-ID: <15d5e7fa-ec5d-422f-9319-d28bed916349@suse.com>
Signed-off-by: default avatarJuergen Gross <jgross@suse.com>
parent 1c3dfc7c

drivers/xen/xenfs/xensyms.c

+2 −2
Original line number Diff line number Diff line
@@ -48,7 +48,7 @@ static int xensyms_next_sym(struct xensyms *xs) 
			return -ENOMEM;



		set_xen_guest_handle(symdata->name, xs->name);

		symdata->symnum--; /* Rewind */

		symdata->symnum = symnum; /* Rewind */



		ret = HYPERVISOR_platform_op(&xs->op);

		if (ret < 0)
@@ -78,7 +78,7 @@ static void *xensyms_next(struct seq_file *m, void *p, loff_t *pos) 
{

	struct xensyms *xs = m->private;



	xs->op.u.symdata.symnum = ++(*pos);

	*pos = xs->op.u.symdata.symnum;



	if (xensyms_next_sym(xs))

		return NULL;