Commit 5c53c122 authored Oct 24, 2023 by Michal Swiatkowski Committed by Tony Nguyen Nov 13, 2023

ice: use repr instead of vf->repr



Extract repr from vf->repr as it is often use in the ice_repr_rem().

Remove meaningless clearing of q_vector and netdev pointers as kfree is
called on repr pointer.

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

parent 7c37bf99

drivers/net/ethernet/intel/ice/ice_repr.c

+7 −7

Original line number	Diff line number	Diff line
		@@ -355,16 +355,16 @@ static int ice_repr_add(struct ice_vf *vf)
		*/
		static void ice_repr_rem(struct ice_vf *vf)
		{
		if (!vf->repr)
		struct ice_repr *repr = vf->repr;

		if (!repr)
		return;

		kfree(vf->repr->q_vector);
		vf->repr->q_vector = NULL;
		unregister_netdev(vf->repr->netdev);
		kfree(repr->q_vector);
		unregister_netdev(repr->netdev);
		ice_devlink_destroy_vf_port(vf);
		free_netdev(vf->repr->netdev);
		vf->repr->netdev = NULL;
		kfree(vf->repr);
		free_netdev(repr->netdev);
		kfree(repr);
		vf->repr = NULL;

		ice_virtchnl_set_dflt_ops(vf);