Commit 5c82a471 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Carlos Maiolino
Browse files

xfs: move invalidate_kernel_vmap_range to xfs_buf_ioend 



Invalidating cache lines can be fairly expensive, so don't do it
in interrupt context.  Note that in practice very few setup will
actually do anything here as virtually indexed caches are rather
uncommon, but we might as well move the call to the proper place
while touching this area.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Acked-by: default avatarDave Chinner <dchinner@redhat.com>
Signed-off-by: default avatarCarlos Maiolino <cem@kernel.org>
parent fac69ec8

fs/xfs/xfs_buf.c

+3 −3
Original line number Diff line number Diff line
@@ -1363,6 +1363,9 @@ xfs_buf_ioend( 
	trace_xfs_buf_iodone(bp, _RET_IP_);



	if (bp->b_flags & XBF_READ) {

		if (!bp->b_error && xfs_buf_is_vmapped(bp))

			invalidate_kernel_vmap_range(bp->b_addr,

					xfs_buf_vmap_len(bp));

		if (!bp->b_error && bp->b_ops)

			bp->b_ops->verify_read(bp);

		if (!bp->b_error)
@@ -1492,9 +1495,6 @@ xfs_buf_bio_end_io( 
		 XFS_TEST_ERROR(false, bp->b_mount, XFS_ERRTAG_BUF_IOERROR))

		xfs_buf_ioerror(bp, -EIO);



	if (!bp->b_error && xfs_buf_is_vmapped(bp) && (bp->b_flags & XBF_READ))

		invalidate_kernel_vmap_range(bp->b_addr, xfs_buf_vmap_len(bp));



	xfs_buf_ioend_async(bp);

	bio_put(bio);

}