Commit 5cd0645b authored by Carlos Llamas's avatar Carlos Llamas Committed by Greg Kroah-Hartman
Browse files

binder: add t->is_async and t->is_reply 



Replace the t->need_reply flag with the more descriptive t->is_async and
and t->is_reply flags. The 'need_reply' flag was only used for debugging
purposes and the new flags can be used to distinguish between the type
of transactions too: sync, async and reply.

For now, only update the logging in print_binder_transaction_ilocked().
However, the new flags can be used in the future to replace the current
patterns and improve readability. e.g.:

  - if (!reply && !(tr->flags & TF_ONE_WAY))
  + if (t->is_async)

This patch is in preparation for binder's generic netlink implementation
and no functional changes are intended.

Signed-off-by: default avatarCarlos Llamas <cmllamas@google.com>
Link: https://lore.kernel.org/r/20250727182932.2499194-3-cmllamas@google.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4afc5bf0

drivers/android/binder.c

+4 −3
Original line number Diff line number Diff line
@@ -3063,6 +3063,8 @@ static void binder_transaction(struct binder_proc *proc, 
	t->flags = tr->flags;

	t->priority = task_nice(current);

	t->work.type = BINDER_WORK_TRANSACTION;

	t->is_async = !reply && (tr->flags & TF_ONE_WAY);

	t->is_reply = reply;

	if (!reply && !(tr->flags & TF_ONE_WAY))

		t->from = thread;
@@ -3708,7 +3710,6 @@ static void binder_transaction(struct binder_proc *proc, 
		 * the target replies (or there is an error).

		 */

		binder_enqueue_deferred_thread_work_ilocked(thread, tcomplete);

		t->need_reply = 1;

		t->from_parent = thread->transaction_stack;

		thread->transaction_stack = t;

		binder_inner_proc_unlock(proc);
@@ -6320,13 +6321,13 @@ static void print_binder_transaction_ilocked(struct seq_file *m, 
	spin_lock(&t->lock);

	to_proc = t->to_proc;

	seq_printf(m,

		   "%s %d: %pK from %d:%d to %d:%d code %x flags %x pri %ld r%d elapsed %lldms",

		   "%s %d: %pK from %d:%d to %d:%d code %x flags %x pri %ld a%d r%d elapsed %lldms",

		   prefix, t->debug_id, t,

		   t->from_pid,

		   t->from_tid,

		   to_proc ? to_proc->pid : 0,

		   t->to_thread ? t->to_thread->pid : 0,

		   t->code, t->flags, t->priority, t->need_reply,

		   t->code, t->flags, t->priority, t->is_async, t->is_reply,

		   ktime_ms_delta(current_time, t->start_time));

	spin_unlock(&t->lock);

drivers/android/binder_internal.h

+2 −2
Original line number Diff line number Diff line
@@ -537,8 +537,8 @@ struct binder_transaction { 
	struct binder_proc *to_proc;

	struct binder_thread *to_thread;

	struct binder_transaction *to_parent;

	unsigned need_reply:1;

	/* unsigned is_dead:1; */       /* not used at the moment */

	unsigned is_async:1;

	unsigned is_reply:1;



	struct binder_buffer *buffer;

	unsigned int    code;