Commit 5cd1a85a authored by Jiapeng Chong's avatar Jiapeng Chong Committed by Rob Herring
Browse files

of: overlay: Remove redundant assignment to ret 



Variable ret is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.

Cleans up the following clang-analyzer warning:

drivers/of/overlay.c:1197:2: warning: Value stored to 'ret' is never
read [clang-analyzer-deadcode.DeadStores].

drivers/of/overlay.c:1026:2: warning: Value stored to 'ret' is never
read [clang-analyzer-deadcode.DeadStores].

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Link: https://lore.kernel.org/r/1619347258-55002-1-git-send-email-jiapeng.chong@linux.alibaba.com


Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent a7277a73

drivers/of/overlay.c

+0 −3
Original line number Diff line number Diff line
@@ -1024,7 +1024,6 @@ int of_overlay_fdt_apply(const void *overlay_fdt, u32 overlay_fdt_size, 
	struct device_node *overlay_root = NULL;



	*ovcs_id = 0;

	ret = 0;



	if (overlay_fdt_size < sizeof(struct fdt_header) ||

	    fdt_check_header(overlay_fdt)) {
@@ -1195,8 +1194,6 @@ int of_overlay_remove(int *ovcs_id) 
	struct overlay_changeset *ovcs;

	int ret, ret_apply, ret_tmp;



	ret = 0;



	if (devicetree_corrupt()) {

		pr_err("suspect devicetree state, refuse to remove overlay\n");

		ret = -EBUSY;