Commit 5cd9fac3 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Paolo Abeni
Browse files

net: sfp-bus: constify link_modes to sfp_select_interface() 



sfp_select_interface() does not modify its link_modes argument, so
make this a const pointer.

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarDaniel Machon <daniel.machon@microchip.com>
Link: https://lore.kernel.org/r/E1s15s0-00AHyq-8E@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 8a3163b6

drivers/net/phy/sfp-bus.c

+1 −1
Original line number Diff line number Diff line
@@ -355,7 +355,7 @@ EXPORT_SYMBOL_GPL(sfp_parse_support); 
 * modes mask.

 */

phy_interface_t sfp_select_interface(struct sfp_bus *bus,

				     unsigned long *link_modes)

				     const unsigned long *link_modes)

{

	if (phylink_test(link_modes, 25000baseCR_Full) ||

	    phylink_test(link_modes, 25000baseKR_Full) ||

include/linux/sfp.h

+2 −2
Original line number Diff line number Diff line
@@ -554,7 +554,7 @@ bool sfp_may_have_phy(struct sfp_bus *bus, const struct sfp_eeprom_id *id); 
void sfp_parse_support(struct sfp_bus *bus, const struct sfp_eeprom_id *id,

		       unsigned long *support, unsigned long *interfaces);

phy_interface_t sfp_select_interface(struct sfp_bus *bus,

				     unsigned long *link_modes);

				     const unsigned long *link_modes);



int sfp_get_module_info(struct sfp_bus *bus, struct ethtool_modinfo *modinfo);

int sfp_get_module_eeprom(struct sfp_bus *bus, struct ethtool_eeprom *ee,
@@ -593,7 +593,7 @@ static inline void sfp_parse_support(struct sfp_bus *bus, 
}



static inline phy_interface_t sfp_select_interface(struct sfp_bus *bus,

						   unsigned long *link_modes)

						const unsigned long *link_modes)

{

	return PHY_INTERFACE_MODE_NA;

}