Commit 5cfb5587 authored by Jonathan Cameron's avatar Jonathan Cameron
Browse files

iio: adc: rzg2l_adc: Use device_for_each_child_node_scoped() 



Switching to the _scoped() version removes the need for manual
calling of fwnode_handle_put() in the paths where the code
exits the loop early. In this case that's all in error paths.

Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: default avatarLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://lore.kernel.org/r/20240224123215.161469-5-jic23@kernel.org


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 8ca555bd

drivers/iio/adc/rzg2l_adc.c

+3 −8
Original line number Diff line number Diff line
@@ -302,7 +302,6 @@ static irqreturn_t rzg2l_adc_isr(int irq, void *dev_id) 
static int rzg2l_adc_parse_properties(struct platform_device *pdev, struct rzg2l_adc *adc)

{

	struct iio_chan_spec *chan_array;

	struct fwnode_handle *fwnode;

	struct rzg2l_adc_data *data;

	unsigned int channel;

	int num_channels;
@@ -330,17 +329,13 @@ static int rzg2l_adc_parse_properties(struct platform_device *pdev, struct rzg2l 
		return -ENOMEM;



	i = 0;

	device_for_each_child_node(&pdev->dev, fwnode) {

	device_for_each_child_node_scoped(&pdev->dev, fwnode) {

		ret = fwnode_property_read_u32(fwnode, "reg", &channel);

		if (ret) {

			fwnode_handle_put(fwnode);

		if (ret)

			return ret;

		}



		if (channel >= RZG2L_ADC_MAX_CHANNELS) {

			fwnode_handle_put(fwnode);

		if (channel >= RZG2L_ADC_MAX_CHANNELS)

			return -EINVAL;

		}



		chan_array[i].type = IIO_VOLTAGE;

		chan_array[i].indexed = 1;