Commit 5d01d2df authored by Tang Yizhou's avatar Tang Yizhou Committed by Jens Axboe
Browse files

blk-wbt: Fix some comments 



wbt_wait() no longer uses a spinlock as a parameter. Update the function
comments accordingly.

RWB_UNKNOWN_BUMP is used when we gradually adjust scale_steps toward the
center state, which is a value of 0.

Signed-off-by: default avatarTang Yizhou <yizhou.tang@shopee.com>
Reviewed-by: default avatarYu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20250213100611.209997-2-yizhou.tang@shopee.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent f4774e92

block/blk-wbt.c

+4 −7
Original line number Diff line number Diff line
@@ -136,8 +136,9 @@ enum { 
	RWB_MIN_WRITE_SAMPLES	= 3,



	/*

	 * If we have this number of consecutive windows with not enough

	 * information to scale up or down, scale up.

	 * If we have this number of consecutive windows without enough

	 * information to scale up or down, slowly return to center state

	 * (step == 0).

	 */

	RWB_UNKNOWN_BUMP	= 5,

};
@@ -638,11 +639,7 @@ static void wbt_cleanup(struct rq_qos *rqos, struct bio *bio) 
	__wbt_done(rqos, flags);

}



/*

 * May sleep, if we have exceeded the writeback limits. Caller can pass

 * in an irq held spinlock, if it holds one when calling this function.

 * If we do sleep, we'll release and re-grab it.

 */

/* May sleep, if we have exceeded the writeback limits. */

static void wbt_wait(struct rq_qos *rqos, struct bio *bio)

{

	struct rq_wb *rwb = RQWB(rqos);