Commit 5d33213f authored by Dan Carpenter's avatar Dan Carpenter Committed by Hans Verkuil
Browse files

media: v4l2-subdev: Fix a 64bit bug 



The problem is this line here from subdev_do_ioctl().

        client_cap->capabilities &= ~V4L2_SUBDEV_CLIENT_CAP_STREAMS;

The "client_cap->capabilities" variable is a u64.  The AND operation
is supposed to clear out the V4L2_SUBDEV_CLIENT_CAP_STREAMS flag.  But
because it's a 32 bit variable it accidentally clears out the high 32
bits as well.

Currently we only use the first bit and none of the upper bits so this
doesn't affect runtime behavior.

Fixes: f57fa295 ("media: v4l2-subdev: Add new ioctl for client capabilities")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent 9ea7be95

include/uapi/linux/v4l2-subdev.h

+1 −1
Original line number Diff line number Diff line
@@ -239,7 +239,7 @@ struct v4l2_subdev_routing { 
 * set (which is the default), the 'stream' fields will be forced to 0 by the

 * kernel.

 */

 #define V4L2_SUBDEV_CLIENT_CAP_STREAMS		(1U << 0)

 #define V4L2_SUBDEV_CLIENT_CAP_STREAMS		(1ULL << 0)



/**

 * struct v4l2_subdev_client_capability - Capabilities of the client accessing