Unverified Commit 5d515eb1 authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/sun4i: hdmi: Fix u64 div on 32bit arch 



Commit 358e76fd ("drm/sun4i: hdmi: Consolidate atomic_check and
mode_valid") changed the clock rate from an unsigned long to an unsigned
long long resulting in a a 64-bit division that might not be supported
on all platforms.

The resulted in compilation being broken at least for m68k, xtensa and
some arm configurations, at least.

Fixes: 358e76fd ("drm/sun4i: hdmi: Consolidate atomic_check and mode_valid")
Reported-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Reported-by: default avatarNaresh Kamboju <naresh.kamboju@linaro.org>
Closes: https://lore.kernel.org/r/CA+G9fYvG9KE15PGNoLu+SBVyShe+u5HBLQ81+kK9Zop6u=ywmw@mail.gmail.com/


Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202403011839.KLiXh4wC-lkp@intel.com/


Acked-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20240304091225.366325-1-mripard@kernel.org


Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
parent 9dd81b2e

drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c

+1 −1
Original line number Diff line number Diff line
@@ -166,7 +166,7 @@ sun4i_hdmi_connector_clock_valid(const struct drm_connector *connector, 
				 unsigned long long clock)

{

	const struct sun4i_hdmi *hdmi = drm_connector_to_sun4i_hdmi(connector);

	unsigned long diff = clock / 200; /* +-0.5% allowed by HDMI spec */

	unsigned long diff = div_u64(clock, 200); /* +-0.5% allowed by HDMI spec */

	long rounded_rate;



	if (mode->flags & DRM_MODE_FLAG_DBLCLK)