Commit 5d650d1e authored by Dawei Li's avatar Dawei Li Committed by Thomas Gleixner
Browse files

irqchip/riscv-aplic-direct: Avoid explicit cpumask allocation on stack 



In general it's preferable to avoid placing cpumasks on the stack, as
for large values of NR_CPUS these can consume significant amounts of
stack space and make stack overflows more likely.

Use cpumask_first_and_and() to avoid the need for a temporary cpumask on
the stack.

Signed-off-by: default avatarDawei Li <dawei.li@shingroup.cn>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarAnup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20240416085454.3547175-6-dawei.li@shingroup.cn
parent 2bc32db5

drivers/irqchip/irq-riscv-aplic-direct.c

+2 −5
Original line number Diff line number Diff line
@@ -54,15 +54,12 @@ static int aplic_direct_set_affinity(struct irq_data *d, const struct cpumask *m 
	struct aplic_direct *direct = container_of(priv, struct aplic_direct, priv);

	struct aplic_idc *idc;

	unsigned int cpu, val;

	struct cpumask amask;

	void __iomem *target;



	cpumask_and(&amask, &direct->lmask, mask_val);



	if (force)

		cpu = cpumask_first(&amask);

		cpu = cpumask_first_and(&direct->lmask, mask_val);

	else

		cpu = cpumask_any_and(&amask, cpu_online_mask);

		cpu = cpumask_first_and_and(&direct->lmask, mask_val, cpu_online_mask);



	if (cpu >= nr_cpu_ids)

		return -EINVAL;