Commit 5d7fb2d5 authored by Claudiu Beznea's avatar Claudiu Beznea Committed by Jonathan Cameron
Browse files

iio: adc: rzg2l_adc: Simplify the locking scheme in rzg2l_adc_read_raw() 



Simplify the locking scheme in rzg2l_adc_read_raw() by using
guard(mutex)().

Signed-off-by: default avatarClaudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: default avatarLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://patch.msgid.link/20241206111337.726244-8-claudiu.beznea.uj@bp.renesas.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent b7549624

drivers/iio/adc/rzg2l_adc.c

+7 −6
Original line number Diff line number Diff line
@@ -8,6 +8,7 @@ 
 */



#include <linux/bitfield.h>

#include <linux/cleanup.h>

#include <linux/completion.h>

#include <linux/delay.h>

#include <linux/iio/iio.h>
@@ -220,21 +221,21 @@ static int rzg2l_adc_read_raw(struct iio_dev *indio_dev, 
	u8 ch;



	switch (mask) {

	case IIO_CHAN_INFO_RAW:

	case IIO_CHAN_INFO_RAW: {

		if (chan->type != IIO_VOLTAGE)

			return -EINVAL;



		mutex_lock(&adc->lock);

		guard(mutex)(&adc->lock);



		ch = chan->channel & RZG2L_ADC_CHN_MASK;

		ret = rzg2l_adc_conversion(indio_dev, adc, ch);

		if (ret) {

			mutex_unlock(&adc->lock);

		if (ret)

			return ret;

		}



		*val = adc->last_val[ch];

		mutex_unlock(&adc->lock);



		return IIO_VAL_INT;

	}



	default:

		return -EINVAL;