Commit 5d89666b authored by Ryan Roberts's avatar Ryan Roberts Committed by Andrew Morton
Browse files

mm: use ptep_get() instead of directly dereferencing pte_t* 

It is best practice for all pte accesses to go via the arch helpers, to
ensure non-torn values and to allow the arch to intervene where needed
(contpte for arm64 for example).  While in this case it was probably safe
to directly dereference, let's tidy it up for consistency.

Link: https://lkml.kernel.org/r/20250310140418.1737409-1-ryan.roberts@arm.com


Signed-off-by: default avatarRyan Roberts <ryan.roberts@arm.com>
Reviewed-by: default avatarLorenzo Stoakes <lorenzo.stoakes@oracle.com>
Reviewed-by: default avatarQi Zheng <zhengqi.arch@bytedance.com>
Reviewed-by: default avatarAnshuman Khandual <anshuman.khandual@arm.com>
Reviewed-by: default avatarDev Jain <dev.jain@arm.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 1a24776f

mm/migrate.c

+1 −1
Original line number Diff line number Diff line
@@ -202,7 +202,7 @@ static bool try_to_map_unused_to_zeropage(struct page_vma_mapped_walk *pvmw, 
		return false;

	VM_BUG_ON_PAGE(!PageAnon(page), page);

	VM_BUG_ON_PAGE(!PageLocked(page), page);

	VM_BUG_ON_PAGE(pte_present(*pvmw->pte), page);

	VM_BUG_ON_PAGE(pte_present(ptep_get(pvmw->pte)), page);



	if (folio_test_mlocked(folio) || (pvmw->vma->vm_flags & VM_LOCKED) ||

	    mm_forbids_zeropage(pvmw->vma->vm_mm))