Commit 5dcf52e2 authored by Mark Brown's avatar Mark Brown Committed by Andrew Morton
Browse files

selftests/mm: fix check for running THP tests 

When testing if we should try to compact memory or drop caches before we
run the THP or HugeTLB tests we use | as an or operator.  This doesn't
work since run_vmtests.sh is written in shell where this is used to pipe
the output of the first argument into the second.  Instead use the shell's
-o operator.

Link: https://lkml.kernel.org/r/20250212-kselftest-mm-no-hugepages-v1-1-44702f538522@kernel.org


Fixes: b433ffa8 ("selftests: mm: perform some system cleanup before using hugepages")
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Reviewed-by: default avatarNico Pache <npache@redhat.com>
Cc: Mariano Pache <npache@redhat.com>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 6d7bc938

tools/testing/selftests/mm/run_vmtests.sh

+1 −1
Original line number Diff line number Diff line
@@ -220,7 +220,7 @@ run_test() { 
	if test_selected ${CATEGORY}; then

		# On memory constrainted systems some tests can fail to allocate hugepages.

		# perform some cleanup before the test for a higher success rate.

		if [ ${CATEGORY} == "thp" ] | [ ${CATEGORY} == "hugetlb" ]; then

		if [ ${CATEGORY} == "thp" -o ${CATEGORY} == "hugetlb" ]; then

			echo 3 > /proc/sys/vm/drop_caches

			sleep 2

			echo 1 > /proc/sys/vm/compact_memory