Commit 5de6951f authored by Zhan Xusheng's avatar Zhan Xusheng Committed by Gao Xiang
Browse files

erofs: ensure all folios are managed in erofs_try_to_free_all_cached_folios()



folio_trylock() in erofs_try_to_free_all_cached_folios() may
successfully acquire the folio lock, but the subsequent check
for erofs_folio_is_managed() can skip unlocking when the folio
is not managed by EROFS.

As Gao Xiang pointed out, this condition should not happen in
practice because compressed_bvecs[] only holds valid cached folios
at this point — any non-managed folio would have already been
detached by z_erofs_cache_release_folio() under folio lock.

Fix this by adding DBG_BUGON() to catch unexpected folios
and ensure folio_unlock() is always called.

Suggested-by: default avatarGao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: default avatarZhan Xusheng <zhanxusheng@xiaomi.com>
Reviewed-by: default avatarGao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: default avatarChunhai Guo <guochunhai@vivo.com>
Signed-off-by: default avatarGao Xiang <hsiangkao@linux.alibaba.com>
parent 307210c2
Loading
Loading
Loading
Loading
+1 −2
Original line number Diff line number Diff line
@@ -605,8 +605,7 @@ static int erofs_try_to_free_all_cached_folios(struct erofs_sb_info *sbi,
			if (!folio_trylock(folio))
				return -EBUSY;

			if (!erofs_folio_is_managed(sbi, folio))
				continue;
			DBG_BUGON(!erofs_folio_is_managed(sbi, folio));
			pcl->compressed_bvecs[i].page = NULL;
			folio_detach_private(folio);
			folio_unlock(folio);