Commit 5de9ea1c authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Jakub Kicinski
Browse files

net: phy: fixed_phy: remove fixed_phy_add 



fixed_phy_add() has a number of problems/disadvantages:
- It uses phy address 0 w/o checking whether a fixed phy with this
  address exists already.
- A subsequent call to fixed_phy_register() would also use phy address 0,
  because fixed_phy_add() doesn't mark it as used.
- fixed_phy_add() is used from platform code, therefore requires that
  fixed_phy code is built-in.

Now that for the only two users (coldfire/5272 and bcm47xx) fixed_phy
creation has been moved to the respective ethernet driver (fec, b44),
we can remove fixed_phy_add().

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/bee046a1-1e77-4057-8b04-fdb2a1bbbd08@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 458639c4

drivers/net/phy/fixed_phy.c

+0 −6
Original line number Diff line number Diff line
@@ -131,12 +131,6 @@ static int __fixed_phy_add(int phy_addr, 
	return 0;

}



void fixed_phy_add(const struct fixed_phy_status *status)

{

	__fixed_phy_add(0, status);

}

EXPORT_SYMBOL_GPL(fixed_phy_add);



static DEFINE_IDA(phy_fixed_ida);



static void fixed_phy_del(int phy_addr)

include/linux/phy_fixed.h

+0 −2
Original line number Diff line number Diff line
@@ -17,7 +17,6 @@ struct net_device; 


#if IS_ENABLED(CONFIG_FIXED_PHY)

extern int fixed_phy_change_carrier(struct net_device *dev, bool new_carrier);

void fixed_phy_add(const struct fixed_phy_status *status);

struct phy_device *fixed_phy_register(const struct fixed_phy_status *status,

				      struct device_node *np);

struct phy_device *fixed_phy_register_100fd(void);
@@ -27,7 +26,6 @@ extern int fixed_phy_set_link_update(struct phy_device *phydev, 
			int (*link_update)(struct net_device *,

					   struct fixed_phy_status *));

#else

static inline void fixed_phy_add(const struct fixed_phy_status *status) {}

static inline struct phy_device *

fixed_phy_register(const struct fixed_phy_status *status,

		   struct device_node *np)