Commit 5dfdcd9e authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: davinci: use generic device properties 



OF-specific routines should not be used unless necessary. Generic device
properties are preferred so switch to using them in the driver code.

Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20241007103440.38416-2-brgl@bgdev.pl


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 56d6ff4b

drivers/gpio/gpio-davinci.c

+3 −5
Original line number Diff line number Diff line
@@ -15,7 +15,6 @@ 
#include <linux/irq.h>

#include <linux/irqdomain.h>

#include <linux/module.h>

#include <linux/of.h>

#include <linux/pinctrl/consumer.h>

#include <linux/platform_device.h>

#include <linux/property.h>
@@ -159,14 +158,13 @@ static int davinci_gpio_probe(struct platform_device *pdev) 
	unsigned int ngpio, nbank, nirq, gpio_unbanked;

	struct davinci_gpio_controller *chips;

	struct device *dev = &pdev->dev;

	struct device_node *dn = dev_of_node(dev);



	/*

	 * The gpio banks conceptually expose a segmented bitmap,

	 * and "ngpio" is one more than the largest zero-based

	 * bit index that's valid.

	 */

	ret = of_property_read_u32(dn, "ti,ngpio", &ngpio);

	ret = device_property_read_u32(dev, "ti,ngpio", &ngpio);

	if (ret)

		return dev_err_probe(dev, ret, "Failed to get the number of GPIOs\n");

	if (ngpio == 0)
@@ -177,7 +175,7 @@ static int davinci_gpio_probe(struct platform_device *pdev) 
	 * interrupts is equal to number of gpios else all are banked so

	 * number of interrupts is equal to number of banks(each with 16 gpios)

	 */

	ret = of_property_read_u32(dn, "ti,davinci-gpio-unbanked",

	ret = device_property_read_u32(dev, "ti,davinci-gpio-unbanked",

				       &gpio_unbanked);

	if (ret)

		return dev_err_probe(dev, ret, "Failed to get the unbanked GPIOs property\n");