Commit 5e0656b1 authored by Vladimir Lypak's avatar Vladimir Lypak Committed by Dmitry Baryshkov
Browse files

drm/msm/dpu: Require linear modifier for writeback framebuffers 



UBWC-related register configuration for writeback is not implemented in
the driver yet but there aren't any checks for non-linear modifiers in
atomic_check. Thus when compressed framebuffer is attached to writeback
connector it will be filled with linear image data. This patch forbids
non-linear modifiers for writeback framebuffers until UBWC support for
writeback is properly implemented.

Fixes: 71174f36 ("drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c")
Signed-off-by: default avatarVladimir Lypak <vladimir.lypak@gmail.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/681922/
Link: https://lore.kernel.org/r/20251017-b4-dpu-fixes-v1-5-40ce5993eeb6@gmail.com


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
parent 2f8bed91

drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c

+3 −0
Original line number Diff line number Diff line
@@ -72,6 +72,9 @@ static int dpu_wb_conn_atomic_check(struct drm_connector *connector, 
		DPU_ERROR("invalid fb w=%d, maxlinewidth=%u\n",

			  fb->width, dpu_wb_conn->maxlinewidth);

		return -EINVAL;

	} else if (fb->modifier != DRM_FORMAT_MOD_LINEAR) {

		DPU_ERROR("unsupported fb modifier:%#llx\n", fb->modifier);

		return -EINVAL;

	}



	return drm_atomic_helper_check_wb_connector_state(conn_state->connector, conn_state->state);