Commit 5e7a74b6 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Jakub Kicinski
Browse files

net: phy: rename phy_set_eee_broken to phy_disable_eee_mode 



Consider that an EEE mode may not be broken but simply not supported
by the MAC, and rename function phy_set_eee_broken().

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/30deb630-3f6b-4ffb-a1e6-a9736021f43a@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8eb0d381

drivers/net/ethernet/realtek/r8169_main.c

+3 −3
Original line number Diff line number Diff line
@@ -5252,9 +5252,9 @@ static int r8169_mdio_register(struct rtl8169_private *tp) 


	/* mimic behavior of r8125/r8126 vendor drivers */

	if (tp->mac_version == RTL_GIGA_MAC_VER_61)

		phy_set_eee_broken(tp->phydev,

		phy_disable_eee_mode(tp->phydev,

				     ETHTOOL_LINK_MODE_2500baseT_Full_BIT);

	phy_set_eee_broken(tp->phydev, ETHTOOL_LINK_MODE_5000baseT_Full_BIT);

	phy_disable_eee_mode(tp->phydev, ETHTOOL_LINK_MODE_5000baseT_Full_BIT);



	/* PHY will be woken up in rtl_open() */

	phy_suspend(tp->phydev);

include/linux/phy.h

+3 −3
Original line number Diff line number Diff line
@@ -1347,11 +1347,11 @@ void of_set_phy_timing_role(struct phy_device *phydev); 
int phy_speed_down_core(struct phy_device *phydev);



/**

 * phy_set_eee_broken - Mark an EEE mode as broken so that it isn't advertised.

 * phy_disable_eee_mode - Don't advertise an EEE mode.

 * @phydev: The phy_device struct

 * @link_mode: The broken EEE mode

 * @link_mode: The EEE mode to be disabled

 */

static inline void phy_set_eee_broken(struct phy_device *phydev, u32 link_mode)

static inline void phy_disable_eee_mode(struct phy_device *phydev, u32 link_mode)

{

	linkmode_set_bit(link_mode, phydev->eee_disabled_modes);

}