Commit 5e7ea65d authored by Michal Grzeschik's avatar Michal Grzeschik Committed by Greg Kroah-Hartman
Browse files

usb: gadget: uvc: refactor the check for a valid buffer in the pump worker 



By toggling the condition check for a valid buffer, the else path
can be completely avoided.

Signed-off-by: default avatarMichael Grzeschik <m.grzeschik@pengutronix.de>
Link: https://lore.kernel.org/r/20240214-uvc-gadget-cleanup-v1-2-de6d78780459@pengutronix.de


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ed6cbac8

drivers/usb/gadget/function/uvc_video.c

+3 −4
Original line number Diff line number Diff line
@@ -594,10 +594,7 @@ static void uvcg_video_pump(struct work_struct *work) 
		 */

		spin_lock_irqsave(&queue->irqlock, flags);

		buf = uvcg_queue_head(queue);



		if (buf != NULL) {

			video->encode(req, video, buf);

		} else {

		if (!buf) {

			/*

			 * Either the queue has been disconnected or no video buffer

			 * available for bulk transfer. Either way, stop processing
@@ -607,6 +604,8 @@ static void uvcg_video_pump(struct work_struct *work) 
			break;

		}



		video->encode(req, video, buf);



		spin_unlock_irqrestore(&queue->irqlock, flags);



		spin_lock_irqsave(&video->req_lock, flags);