Unverified Commit 5eb4b9a4 authored by Thorsten Blum's avatar Thorsten Blum Committed by Daniel Gomez
Browse files

params: Replace deprecated strcpy() with strscpy() and memcpy() 

strcpy() is deprecated; use strscpy() and memcpy() instead.

In param_set_copystring(), we can safely use memcpy() because we already
know the length of the source string 'val' and that it is guaranteed to
be NUL-terminated within the first 'kps->maxlen' bytes.

Link: https://github.com/KSPP/linux/issues/88


Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: default avatarDaniel Gomez <da.gomez@samsung.com>
Reviewed-by: default avatarPetr Pavlu <petr.pavlu@suse.com>
Link: https://lore.kernel.org/r/20250813132200.184064-2-thorsten.blum@linux.dev


Signed-off-by: default avatarDaniel Gomez <da.gomez@samsung.com>
parent 8f5ae30d

kernel/params.c

+4 −3
Original line number Diff line number Diff line
@@ -513,13 +513,14 @@ EXPORT_SYMBOL(param_array_ops); 
int param_set_copystring(const char *val, const struct kernel_param *kp)

{

	const struct kparam_string *kps = kp->str;

	const size_t len = strnlen(val, kps->maxlen);



	if (strnlen(val, kps->maxlen) == kps->maxlen) {

	if (len == kps->maxlen) {

		pr_err("%s: string doesn't fit in %u chars.\n",

		       kp->name, kps->maxlen-1);

		return -ENOSPC;

	}

	strcpy(kps->string, val);

	memcpy(kps->string, val, len + 1);

	return 0;

}

EXPORT_SYMBOL(param_set_copystring);
@@ -841,7 +842,7 @@ static void __init param_sysfs_builtin(void) 
		dot = strchr(kp->name, '.');

		if (!dot) {

			/* This happens for core_param() */

			strcpy(modname, "kernel");

			strscpy(modname, "kernel");

			name_len = 0;

		} else {

			name_len = dot - kp->name + 1;