Unverified Commit 5ec820fc authored by Marek Vasut's avatar Marek Vasut Committed by Stephen Boyd
Browse files

clk: rs9: Reserve 8 struct clk_hw slots for for 9FGV0841 



The 9FGV0841 has 8 outputs and registers 8 struct clk_hw, make sure
there are 8 slots for those newly registered clk_hw pointers, else
there is going to be out of bounds write when pointers 4..7 are set
into struct rs9_driver_data .clk_dif[4..7] field.

Since there are other structure members past this struct clk_hw
pointer array, writing to .clk_dif[4..7] fields corrupts both
the struct rs9_driver_data content and data around it, sometimes
without crashing the kernel. However, the kernel does surely
crash when the driver is unbound or during suspend.

Fix this, increase the struct clk_hw pointer array size to the
maximum output count of 9FGV0841, which is the biggest chip that
is supported by this driver.

Cc: stable@vger.kernel.org
Fixes: f0e5e180 ("clk: rs9: Add support for 9FGV0841")
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Tested-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reported-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Closes: https://lore.kernel.org/CAMuHMdVyQpOBT+Ho+mXY07fndFN9bKJdaaWGn91WOFnnYErLyg@mail.gmail.com


Signed-off-by: default avatarMarek Vasut <marek.vasut+renesas@mailbox.org>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 83436f2b

drivers/clk/clk-renesas-pcie.c

+1 −1
Original line number Diff line number Diff line
@@ -64,7 +64,7 @@ struct rs9_driver_data { 
	struct i2c_client	*client;

	struct regmap		*regmap;

	const struct rs9_chip_info *chip_info;

	struct clk_hw		*clk_dif[4];

	struct clk_hw		*clk_dif[8];

	u8			pll_amplitude;

	u8			pll_ssc;

	u8			clk_dif_sr;