Commit 5efa8249 authored by Heiko Stuebner's avatar Heiko Stuebner
Browse files

drm/panel: ilitek-ili9881c: move display_on/_off dcs calls to (un-)prepare 



At least for panel-bridges, the atomic_enable call is defined as being
called right after the preceding element in the display pipe is enabled.

It is also stated that "The bridge can assume that the display pipe (i.e.
clocks and timing signals) feeding it is running when this callback is
called"

This means the DSI controller driving this display would have already
switched over to video-mode from command mode and thus dcs functions
should not be called anymore at this point.

This caused a non-working display for me, when trying to enable
the rk3576 dsi controller using a display using this controller.

Therefore move the display_on/off calls the more appropriate
prepare/unprepare callbacks.

Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20250707164906.1445288-3-heiko@sntech.de
parent 6c66eba5

drivers/gpu/drm/panel/panel-ilitek-ili9881c.c

+7 −20
Original line number Diff line number Diff line
@@ -1509,35 +1509,24 @@ static int ili9881c_prepare(struct drm_panel *panel) 
	if (ret)

		goto disable_power;



	return 0;



disable_power:

	regulator_disable(ctx->power);

	return ret;

}



static int ili9881c_enable(struct drm_panel *panel)

{

	struct ili9881c *ctx = panel_to_ili9881c(panel);



	msleep(120);



	mipi_dsi_dcs_set_display_on(ctx->dsi);

	ret = mipi_dsi_dcs_set_display_on(ctx->dsi);

	if (ret)

		goto disable_power;



	return 0;

}



static int ili9881c_disable(struct drm_panel *panel)

{

	struct ili9881c *ctx = panel_to_ili9881c(panel);



	return mipi_dsi_dcs_set_display_off(ctx->dsi);

disable_power:

	regulator_disable(ctx->power);

	return ret;

}



static int ili9881c_unprepare(struct drm_panel *panel)

{

	struct ili9881c *ctx = panel_to_ili9881c(panel);



	mipi_dsi_dcs_set_display_off(ctx->dsi);

	mipi_dsi_dcs_enter_sleep_mode(ctx->dsi);

	regulator_disable(ctx->power);

	gpiod_set_value_cansleep(ctx->reset, 1);
@@ -1710,8 +1699,6 @@ static enum drm_panel_orientation ili9881c_get_orientation(struct drm_panel *pan 
static const struct drm_panel_funcs ili9881c_funcs = {

	.prepare	= ili9881c_prepare,

	.unprepare	= ili9881c_unprepare,

	.enable		= ili9881c_enable,

	.disable	= ili9881c_disable,

	.get_modes	= ili9881c_get_modes,

	.get_orientation = ili9881c_get_orientation,

};