Commit 5f258053 authored by Vasily Gorbik's avatar Vasily Gorbik
Browse files

s390/xor: Fix xor_xc_5() inline assembly 



xor_xc_5() contains a larl 1,2f that is not used by the asm and is not
declared as a clobber. This can corrupt a compiler-allocated value in %r1
and lead to miscompilation. Remove the instruction.

Fixes: 745600ed ("s390/lib: Use exrl instead of ex in xor functions")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarJuergen Christ <jchrist@linux.ibm.com>
Reviewed-by: default avatarHeiko Carstens <hca@linux.ibm.com>
Reviewed-by: default avatarSven Schnelle <svens@linux.ibm.com>
Signed-off-by: default avatarVasily Gorbik <gor@linux.ibm.com>
parent 11439c46

arch/s390/lib/xor.c

+0 −1
Original line number Diff line number Diff line
@@ -96,7 +96,6 @@ static void xor_xc_5(unsigned long bytes, unsigned long * __restrict p1, 
		     const unsigned long * __restrict p5)

{

	asm volatile(

		"	larl	1,2f\n"

		"	aghi	%0,-1\n"

		"	jm	6f\n"

		"	srlg	0,%0,8\n"