Commit 5f4476e9 authored by Danilo Krummrich's avatar Danilo Krummrich
Browse files

rust: auxiliary: add Driver::unbind() callback 



Add missing unbind() callback to auxiliary::Driver, since it will be
needed by drivers eventually (e.g. the Nova DRM driver).

Acked-by: default avatarAlice Ryhl <aliceryhl@google.com>
Link: https://patch.msgid.link/20260107103511.570525-3-dakr@kernel.org


Signed-off-by: default avatarDanilo Krummrich <dakr@kernel.org>
parent 4181aceb

rust/kernel/auxiliary.rs

+17 −1
Original line number Diff line number Diff line
@@ -87,7 +87,9 @@ extern "C" fn remove_callback(adev: *mut bindings::auxiliary_device) { 
        // SAFETY: `remove_callback` is only ever called after a successful call to

        // `probe_callback`, hence it's guaranteed that `Device::set_drvdata()` has been called

        // and stored a `Pin<KBox<T>>`.

        drop(unsafe { adev.as_ref().drvdata_obtain::<T>() });

        let data = unsafe { adev.as_ref().drvdata_obtain::<T>() };



        T::unbind(adev, data.as_ref());

    }

}
@@ -187,6 +189,20 @@ pub trait Driver { 
    ///

    /// Called when an auxiliary device is matches a corresponding driver.

    fn probe(dev: &Device<device::Core>, id_info: &Self::IdInfo) -> impl PinInit<Self, Error>;



    /// Auxiliary driver unbind.

    ///

    /// Called when a [`Device`] is unbound from its bound [`Driver`]. Implementing this callback

    /// is optional.

    ///

    /// This callback serves as a place for drivers to perform teardown operations that require a

    /// `&Device<Core>` or `&Device<Bound>` reference. For instance, drivers may try to perform I/O

    /// operations to gracefully tear down the device.

    ///

    /// Otherwise, release operations for driver resources should be performed in `Self::drop`.

    fn unbind(dev: &Device<device::Core>, this: Pin<&Self>) {

        let _ = (dev, this);

    }

}



/// The auxiliary device representation.