Commit 5f465c14 authored by Xin Li (Intel)'s avatar Xin Li (Intel) Committed by Dave Hansen
Browse files

x86/traps: Initialize DR6 by writing its architectural reset value 



Initialize DR6 by writing its architectural reset value to avoid
incorrectly zeroing DR6 to clear DR6.BLD at boot time, which leads
to a false bus lock detected warning.

The Intel SDM says:

  1) Certain debug exceptions may clear bits 0-3 of DR6.

  2) BLD induced #DB clears DR6.BLD and any other debug exception
     doesn't modify DR6.BLD.

  3) RTM induced #DB clears DR6.RTM and any other debug exception
     sets DR6.RTM.

  To avoid confusion in identifying debug exceptions, debug handlers
  should set DR6.BLD and DR6.RTM, and clear other DR6 bits before
  returning.

The DR6 architectural reset value 0xFFFF0FF0, already defined as
macro DR6_RESERVED, satisfies these requirements, so just use it to
reinitialize DR6 whenever needed.

Since clear_all_debug_regs() no longer zeros all debug registers,
rename it to initialize_debug_regs() to better reflect its current
behavior.

Since debug_read_clear_dr6() no longer clears DR6, rename it to
debug_read_reset_dr6() to better reflect its current behavior.

Fixes: ebb1064e ("x86/traps: Handle #DB for bus lock")
Reported-by: default avatarSohil Mehta <sohil.mehta@intel.com>
Suggested-by: default avatarH. Peter Anvin (Intel) <hpa@zytor.com>
Signed-off-by: default avatarXin Li (Intel) <xin@zytor.com>
Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: default avatarH. Peter Anvin (Intel) <hpa@zytor.com>
Reviewed-by: default avatarSohil Mehta <sohil.mehta@intel.com>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: default avatarSohil Mehta <sohil.mehta@intel.com>
Link: https://lore.kernel.org/lkml/06e68373-a92b-472e-8fd9-ba548119770c@intel.com/
Cc:stable@vger.kernel.org
Link: https://lore.kernel.org/all/20250620231504.2676902-2-xin%40zytor.com
parent 2aebf5ee

arch/x86/include/uapi/asm/debugreg.h

+20 −1
Original line number Diff line number Diff line
@@ -15,7 +15,26 @@ 
   which debugging register was responsible for the trap.  The other bits

   are either reserved or not of interest to us. */



/* Define reserved bits in DR6 which are always set to 1 */

/*

 * Define bits in DR6 which are set to 1 by default.

 *

 * This is also the DR6 architectural value following Power-up, Reset or INIT.

 *

 * Note, with the introduction of Bus Lock Detection (BLD) and Restricted

 * Transactional Memory (RTM), the DR6 register has been modified:

 *

 * 1) BLD flag (bit 11) is no longer reserved to 1 if the CPU supports

 *    Bus Lock Detection.  The assertion of a bus lock could clear it.

 *

 * 2) RTM flag (bit 16) is no longer reserved to 1 if the CPU supports

 *    restricted transactional memory.  #DB occurred inside an RTM region

 *    could clear it.

 *

 * Apparently, DR6.BLD and DR6.RTM are active low bits.

 *

 * As a result, DR6_RESERVED is an incorrect name now, but it is kept for

 * compatibility.

 */

#define DR6_RESERVED	(0xFFFF0FF0)



#define DR_TRAP0	(0x1)		/* db0 */

arch/x86/kernel/cpu/common.c

+10 −14
Original line number Diff line number Diff line
@@ -2243,20 +2243,16 @@ EXPORT_PER_CPU_SYMBOL(__stack_chk_guard); 
#endif

#endif



/*

 * Clear all 6 debug registers:

 */

static void clear_all_debug_regs(void)

static void initialize_debug_regs(void)

{

	int i;



	for (i = 0; i < 8; i++) {

		/* Ignore db4, db5 */

		if ((i == 4) || (i == 5))

			continue;



		set_debugreg(0, i);

	}

	/* Control register first -- to make sure everything is disabled. */

	set_debugreg(0, 7);

	set_debugreg(DR6_RESERVED, 6);

	/* dr5 and dr4 don't exist */

	set_debugreg(0, 3);

	set_debugreg(0, 2);

	set_debugreg(0, 1);

	set_debugreg(0, 0);

}



#ifdef CONFIG_KGDB
@@ -2417,7 +2413,7 @@ void cpu_init(void) 


	load_mm_ldt(&init_mm);



	clear_all_debug_regs();

	initialize_debug_regs();

	dbg_restore_debug_regs();



	doublefault_init_cpu_tss();

arch/x86/kernel/traps.c

+21 −13
Original line number Diff line number Diff line
@@ -1022,24 +1022,32 @@ static bool is_sysenter_singlestep(struct pt_regs *regs) 
#endif

}



static __always_inline unsigned long debug_read_clear_dr6(void)

static __always_inline unsigned long debug_read_reset_dr6(void)

{

	unsigned long dr6;



	get_debugreg(dr6, 6);

	dr6 ^= DR6_RESERVED; /* Flip to positive polarity */



	/*

	 * The Intel SDM says:

	 *

	 *   Certain debug exceptions may clear bits 0-3. The remaining

	 *   contents of the DR6 register are never cleared by the

	 *   processor. To avoid confusion in identifying debug

	 *   exceptions, debug handlers should clear the register before

	 *   returning to the interrupted task.

	 *   Certain debug exceptions may clear bits 0-3 of DR6.

	 *

	 *   BLD induced #DB clears DR6.BLD and any other debug

	 *   exception doesn't modify DR6.BLD.

	 *

	 * Keep it simple: clear DR6 immediately.

	 *   RTM induced #DB clears DR6.RTM and any other debug

	 *   exception sets DR6.RTM.

	 *

	 *   To avoid confusion in identifying debug exceptions,

	 *   debug handlers should set DR6.BLD and DR6.RTM, and

	 *   clear other DR6 bits before returning.

	 *

	 * Keep it simple: write DR6 with its architectural reset

	 * value 0xFFFF0FF0, defined as DR6_RESERVED, immediately.

	 */

	get_debugreg(dr6, 6);

	set_debugreg(DR6_RESERVED, 6);

	dr6 ^= DR6_RESERVED; /* Flip to positive polarity */



	return dr6;

}
@@ -1239,13 +1247,13 @@ static noinstr void exc_debug_user(struct pt_regs *regs, unsigned long dr6) 
/* IST stack entry */

DEFINE_IDTENTRY_DEBUG(exc_debug)

{

	exc_debug_kernel(regs, debug_read_clear_dr6());

	exc_debug_kernel(regs, debug_read_reset_dr6());

}



/* User entry, runs on regular task stack */

DEFINE_IDTENTRY_DEBUG_USER(exc_debug)

{

	exc_debug_user(regs, debug_read_clear_dr6());

	exc_debug_user(regs, debug_read_reset_dr6());

}



#ifdef CONFIG_X86_FRED
@@ -1264,7 +1272,7 @@ DEFINE_FREDENTRY_DEBUG(exc_debug) 
{

	/*

	 * FRED #DB stores DR6 on the stack in the format which

	 * debug_read_clear_dr6() returns for the IDT entry points.

	 * debug_read_reset_dr6() returns for the IDT entry points.

	 */

	unsigned long dr6 = fred_event_data(regs);
@@ -1279,7 +1287,7 @@ DEFINE_FREDENTRY_DEBUG(exc_debug) 
/* 32 bit does not have separate entry points. */

DEFINE_IDTENTRY_RAW(exc_debug)

{

	unsigned long dr6 = debug_read_clear_dr6();

	unsigned long dr6 = debug_read_reset_dr6();



	if (user_mode(regs))

		exc_debug_user(regs, dr6);