Commit 5f4696dd authored by Samuel Holland's avatar Samuel Holland Committed by Jernej Skrabec
Browse files

bus: sunxi-rsb: Remove the shutdown callback 



Shutting down the RSB controller prevents communicating with a PMIC
inside pm_power_off(), since that gets called after device_shutdown(),
so it breaks system poweroff on some boards.

Reported-by: default avatarIvaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Tested-by: default avatarIvaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Acked-by: default avatarJernej Skrabec <jernej.skrabec@gmail.com>
Fixes: 84310749 ("bus: sunxi-rsb: Implement suspend/resume/shutdown callbacks")
Signed-off-by: default avatarSamuel Holland <samuel@sholland.org>
Link: https://lore.kernel.org/r/20221114015749.28490-2-samuel@sholland.org


Signed-off-by: default avatarJernej Skrabec <jernej.skrabec@gmail.com>
parent 9abf2313

drivers/bus/sunxi-rsb.c

+0 −9
Original line number Diff line number Diff line
@@ -812,14 +812,6 @@ static int sunxi_rsb_remove(struct platform_device *pdev) 
	return 0;

}



static void sunxi_rsb_shutdown(struct platform_device *pdev)

{

	struct sunxi_rsb *rsb = platform_get_drvdata(pdev);



	pm_runtime_disable(&pdev->dev);

	sunxi_rsb_hw_exit(rsb);

}



static const struct dev_pm_ops sunxi_rsb_dev_pm_ops = {

	SET_RUNTIME_PM_OPS(sunxi_rsb_runtime_suspend,

			   sunxi_rsb_runtime_resume, NULL)
@@ -835,7 +827,6 @@ MODULE_DEVICE_TABLE(of, sunxi_rsb_of_match_table); 
static struct platform_driver sunxi_rsb_driver = {

	.probe = sunxi_rsb_probe,

	.remove	= sunxi_rsb_remove,

	.shutdown = sunxi_rsb_shutdown,

	.driver	= {

		.name = RSB_CTRL_NAME,

		.of_match_table = sunxi_rsb_of_match_table,