Commit 5f710e3b authored by Claudiu Beznea's avatar Claudiu Beznea Committed by Geert Uytterhoeven
Browse files

clk: renesas: rzg2l: Remove critical area 



The spinlock in rzg2l_mod_clock_endisable() is intended to protect
RMW-accesses to the hardware register.  There is no need to protect
instructions that set temporary variables which will be written
afterwards to a hardware register.  With this only one write to one
clock register is executed thus locking/unlocking rmw_lock is removed.

Signed-off-by: default avatarClaudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20230929053915.1530607-7-claudiu.beznea@bp.renesas.com


Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
parent a2b23159

drivers/clk/renesas/rzg2l-cpg.c

+1 −4
Original line number Diff line number Diff line
@@ -895,7 +895,6 @@ static int rzg2l_mod_clock_endisable(struct clk_hw *hw, bool enable) 
	struct rzg2l_cpg_priv *priv = clock->priv;

	unsigned int reg = clock->off;

	struct device *dev = priv->dev;

	unsigned long flags;

	u32 bitmask = BIT(clock->bit);

	u32 value;

	int error;
@@ -907,14 +906,12 @@ static int rzg2l_mod_clock_endisable(struct clk_hw *hw, bool enable) 


	dev_dbg(dev, "CLK_ON %u/%pC %s\n", CLK_ON_R(reg), hw->clk,

		enable ? "ON" : "OFF");

	spin_lock_irqsave(&priv->rmw_lock, flags);



	value = bitmask << 16;

	if (enable)

		value |= bitmask;

	writel(value, priv->base + CLK_ON_R(reg));



	spin_unlock_irqrestore(&priv->rmw_lock, flags);

	writel(value, priv->base + CLK_ON_R(reg));



	if (!enable)

		return 0;