Commit 5f994f53 authored by Jinjie Ruan's avatar Jinjie Ruan Committed by Thomas Gleixner
Browse files

genirq/msi: Fix off-by-one error in msi_domain_alloc() 



The error path in msi_domain_alloc(), frees the already allocated MSI
interrupts in a loop, but the loop condition terminates when the index
reaches zero, which fails to free the first allocated MSI interrupt at
index zero.

Check for >= 0 so that msi[0] is freed as well.

Fixes: f3cf8bb0 ("genirq: Add generic msi irq domain support")
Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20241026063639.10711-1-ruanjinjie@huawei.com
parent 42f7652d

kernel/irq/msi.c

+1 −1
Original line number Diff line number Diff line
@@ -718,7 +718,7 @@ static int msi_domain_alloc(struct irq_domain *domain, unsigned int virq, 
		ret = ops->msi_init(domain, info, virq + i, hwirq + i, arg);

		if (ret < 0) {

			if (ops->msi_free) {

				for (i--; i > 0; i--)

				for (i--; i >= 0; i--)

					ops->msi_free(domain, info, virq + i);

			}

			irq_domain_free_irqs_top(domain, virq, nr_irqs);