Commit 5f9fcbf9 authored by Dan Carpenter's avatar Dan Carpenter Committed by Hans Verkuil
Browse files

media: nuvoton: npcm-video: Fix IS_ERR() vs NULL bug 



The of_parse_phandle() function returns NULL on error.  It never returns
error pointers.  Update the check accordingly.

Fixes: 70721089985c ("media: nuvoton: Add driver for NPCM video capture and encoding engine")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent 04d19e65

drivers/media/platform/nuvoton/npcm-video.c

+2 −2
Original line number Diff line number Diff line
@@ -1660,9 +1660,9 @@ static int npcm_video_ece_init(struct npcm_video *video) 
	void __iomem *regs;



	ece_node = of_parse_phandle(video->dev->of_node, "nuvoton,ece", 0);

	if (IS_ERR(ece_node)) {

	if (!ece_node) {

		dev_err(dev, "Failed to get ECE phandle in DTS\n");

		return PTR_ERR(ece_node);

		return -ENODEV;

	}



	video->ece.enable = of_device_is_available(ece_node);