Commit 5fa43628 authored by Lang Yu's avatar Lang Yu Committed by Alex Deucher
Browse files

drm/amdkfd: Fix an eviction fence leak 



Only creating a new reference for each process instead of each VM.

Fixes: 9a1c1339 ("drm/amdkfd: Run restore_workers on freezable WQs")
Suggested-by: default avatarFelix Kuehling <felix.kuehling@amd.com>
Signed-off-by: default avatarLang Yu <lang.yu@amd.com>
Reviewed-by: default avatarFelix Kuehling <felix.kuehling@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent ef532206

drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c

+2 −2
Original line number Diff line number Diff line
@@ -1439,7 +1439,7 @@ static int init_kfd_vm(struct amdgpu_vm *vm, void **process_info, 
	list_add_tail(&vm->vm_list_node,

			&(vm->process_info->vm_list_head));

	vm->process_info->n_vms++;



	if (ef)

		*ef = dma_fence_get(&vm->process_info->eviction_fence->base);

	mutex_unlock(&vm->process_info->lock);

drivers/gpu/drm/amd/amdkfd/kfd_process.c

+5 −2
Original line number Diff line number Diff line
@@ -1702,12 +1702,15 @@ int kfd_process_device_init_vm(struct kfd_process_device *pdd, 


	ret = amdgpu_amdkfd_gpuvm_acquire_process_vm(dev->adev, avm,

						     &p->kgd_process_info,

						     &ef);

						     p->ef ? NULL : &ef);

	if (ret) {

		dev_err(dev->adev->dev, "Failed to create process VM object\n");

		return ret;

	}



	if (!p->ef)

		RCU_INIT_POINTER(p->ef, ef);



	pdd->drm_priv = drm_file->private_data;



	ret = kfd_process_device_reserve_ib_mem(pdd);