Commit 5fbf37e5 authored by Li Zhijian's avatar Li Zhijian Committed by Martin K. Petersen
Browse files

scsi: isci: Convert snprintf() to sysfs_emit() 



Per filesystems/sysfs.rst, show() should only use sysfs_emit() or
sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

> ./drivers/scsi/isci/init.c:140:8-16: WARNING: please use sysfs_emit

No functional change intended

CC: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
CC: James E.J. Bottomley <jejb@linux.ibm.com>
CC: Martin K. Petersen <martin.petersen@oracle.com>
CC: linux-scsi@vger.kernel.org
Signed-off-by: default avatarLi Zhijian <lizhijian@fujitsu.com>
Link: https://lore.kernel.org/r/20240116045151.3940401-25-lizhijian@fujitsu.com


Reviewed-by: default avatarArtur Paszkiewicz <artur.paszkiewicz@intel.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 01105c23

drivers/scsi/isci/init.c

+1 −1
Original line number Diff line number Diff line
@@ -137,7 +137,7 @@ static ssize_t isci_show_id(struct device *dev, struct device_attribute *attr, c 
	struct sas_ha_struct *sas_ha = SHOST_TO_SAS_HA(shost);

	struct isci_host *ihost = container_of(sas_ha, typeof(*ihost), sas_ha);



	return snprintf(buf, PAGE_SIZE, "%d\n", ihost->id);

	return sysfs_emit(buf, "%d\n", ihost->id);

}



static DEVICE_ATTR(isci_id, S_IRUGO, isci_show_id, NULL);