Commit 5fd0268a authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

block: mark bounce buffering as incompatible with integrity 



None of the few drivers still using the legacy block layer bounce
buffering support integrity metadata.  Explicitly mark the features as
incompatible and stop creating the slab and mempool for integrity
buffers for the bounce bio_set.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarAnuj Gupta <anuj20.g@samsung.com>
Reviewed-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Reviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Link: https://lore.kernel.org/r/20250225154449.422989-2-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 567abc98

block/blk-settings.c

+5 −0
Original line number Diff line number Diff line
@@ -117,6 +117,11 @@ static int blk_validate_integrity_limits(struct queue_limits *lim) 
		return 0;

	}



	if (lim->features & BLK_FEAT_BOUNCE_HIGH) {

		pr_warn("no bounce buffer support for integrity metadata\n");

		return -EINVAL;

	}



	if (!IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY)) {

		pr_warn("integrity support disabled.\n");

		return -EINVAL;

block/bounce.c

+0 −2
Original line number Diff line number Diff line
@@ -41,8 +41,6 @@ static void init_bounce_bioset(void) 


	ret = bioset_init(&bounce_bio_set, BIO_POOL_SIZE, 0, BIOSET_NEED_BVECS);

	BUG_ON(ret);

	if (bioset_integrity_create(&bounce_bio_set, BIO_POOL_SIZE))

		BUG_ON(1);



	ret = bioset_init(&bounce_bio_split, BIO_POOL_SIZE, 0, 0);

	BUG_ON(ret);