Commit 5fdb4b34 authored by Chenghai Huang's avatar Chenghai Huang Committed by Herbert Xu
Browse files

crypto: hisilicon - add a lock for the qp send operation 



Apply for a lock before the qp send operation to ensure no
resource race in multi-concurrency situations.

This modification has almost no impact on performance.

Signed-off-by: default avatarChenghai Huang <huangchenghai2@huawei.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent f386dc64

drivers/crypto/hisilicon/hpre/hpre_crypto.c

+2 −0
Original line number Diff line number Diff line
@@ -575,7 +575,9 @@ static int hpre_send(struct hpre_ctx *ctx, struct hpre_sqe *msg) 


	do {

		atomic64_inc(&dfx[HPRE_SEND_CNT].value);

		spin_lock_bh(&ctx->req_lock);

		ret = hisi_qp_send(ctx->qp, msg);

		spin_unlock_bh(&ctx->req_lock);

		if (ret != -EBUSY)

			break;

		atomic64_inc(&dfx[HPRE_SEND_BUSY_CNT].value);

drivers/crypto/hisilicon/zip/zip_crypto.c

+3 −0
Original line number Diff line number Diff line
@@ -213,6 +213,7 @@ static int hisi_zip_do_work(struct hisi_zip_qp_ctx *qp_ctx, 
{

	struct hisi_acc_sgl_pool *pool = qp_ctx->sgl_pool;

	struct hisi_zip_dfx *dfx = &qp_ctx->zip_dev->dfx;

	struct hisi_zip_req_q *req_q = &qp_ctx->req_q;

	struct acomp_req *a_req = req->req;

	struct hisi_qp *qp = qp_ctx->qp;

	struct device *dev = &qp->qm->pdev->dev;
@@ -244,7 +245,9 @@ static int hisi_zip_do_work(struct hisi_zip_qp_ctx *qp_ctx, 


	/* send command to start a task */

	atomic64_inc(&dfx->send_cnt);

	spin_lock_bh(&req_q->req_lock);

	ret = hisi_qp_send(qp, &zip_sqe);

	spin_unlock_bh(&req_q->req_lock);

	if (unlikely(ret < 0)) {

		atomic64_inc(&dfx->send_busy_cnt);

		ret = -EAGAIN;