Commit 5feac4d7 authored by Andy Shevchenko's avatar Andy Shevchenko
Browse files

pinctrl: lynxpoint: Use dedicated helpers for chained IRQ handlers 



Instead of relying on the fact that the parent IRQ chip supports
fasteoi mode and calling the respective callback at the end of
the interrupt handler, surround it with enter and exit helpers
for chained IRQ handlers which will consider all possible cases.

This in particular unifies how GPIO drivers handle IRQ.

Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 8e54033b

drivers/pinctrl/intel/pinctrl-lynxpoint.c

+4 −1
Original line number Diff line number Diff line
@@ -549,6 +549,8 @@ static void lp_gpio_irq_handler(struct irq_desc *desc) 
	unsigned long pending;

	u32 base, pin;



	chained_irq_enter(chip, desc);



	/* check from GPIO controller which pin triggered the interrupt */

	for (base = 0; base < lg->chip.ngpio; base += 32) {

		reg = lp_gpio_reg(&lg->chip, base, LP_INT_STAT);
@@ -560,7 +562,8 @@ static void lp_gpio_irq_handler(struct irq_desc *desc) 
		for_each_set_bit(pin, &pending, 32)

			generic_handle_domain_irq(lg->chip.irq.domain, base + pin);

	}

	chip->irq_eoi(data);



	chained_irq_exit(chip, desc);

}



static void lp_irq_ack(struct irq_data *d)