Commit 5ff3f74e authored by Keith Busch's avatar Keith Busch Committed by Jens Axboe
Browse files

block: simplify direct io validity check 



The block layer checks all the segments for validity later, so no need
for an early check. Just reduce it to a simple position and total length
check, and defer the more invasive segment checks to the block layer.

Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Reviewed-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 20a0e627

block/fops.c

+2 −2
Original line number Diff line number Diff line
@@ -38,8 +38,8 @@ static blk_opf_t dio_bio_write_op(struct kiocb *iocb) 
static bool blkdev_dio_invalid(struct block_device *bdev, struct kiocb *iocb,

				struct iov_iter *iter)

{

	return iocb->ki_pos & (bdev_logical_block_size(bdev) - 1) ||

		!bdev_iter_is_aligned(bdev, iter);

	return (iocb->ki_pos | iov_iter_count(iter)) &

			(bdev_logical_block_size(bdev) - 1);

}



#define DIO_INLINE_BIO_VECS 4