Commit 6010d4d8 authored by Jared Kangas's avatar Jared Kangas Committed by Linus Walleij
Browse files

pinctrl: s32cc: initialize gpio_pin_config::list after kmalloc() 



s32_pmx_gpio_request_enable() does not initialize the newly-allocated
gpio_pin_config::list before adding it to s32_pinctrl::gpio_configs.
This could result in a linked list corruption.

Initialize the new list_head with INIT_LIST_HEAD() to fix this.

Fixes: fd84aaa8 ("pinctrl: add NXP S32 SoC family support")
Signed-off-by: default avatarJared Kangas <jkangas@redhat.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 97ea34de

drivers/pinctrl/nxp/pinctrl-s32cc.c

+1 −0
Original line number Diff line number Diff line
@@ -392,6 +392,7 @@ static int s32_pmx_gpio_request_enable(struct pinctrl_dev *pctldev, 


	gpio_pin->pin_id = offset;

	gpio_pin->config = config;

	INIT_LIST_HEAD(&gpio_pin->list);



	spin_lock_irqsave(&ipctl->gpio_configs_lock, flags);

	list_add(&gpio_pin->list, &ipctl->gpio_configs);