Commit 6018f2fe authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Takashi Iwai
Browse files

ALSA: compress_offload: avoid 64-bit get_user() 



On some architectures, get_user() cannot read a 64-bit user variable:

arm-linux-gnueabi-ld: sound/core/compress_offload.o: in function `snd_compr_ioctl':
compress_offload.c:(.text.snd_compr_ioctl+0x538): undefined reference to `__get_user_bad'

Use an equivalent copy_from_user() instead.

Fixes: 04177158 ("ALSA: compress_offload: introduce accel operation mode")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Acked-by: default avatarShengjiu Wang <shengjiu.wang@gmail.com>
Acked-by: default avatarVinod Koul <vkoul@kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20241216093410.377112-2-arnd@kernel.org
parent 1ae40d52

sound/core/compress_offload.c

+3 −3
Original line number Diff line number Diff line
@@ -1180,9 +1180,9 @@ static int snd_compr_task_seq(struct snd_compr_stream *stream, unsigned long arg 


	if (stream->runtime->state != SNDRV_PCM_STATE_SETUP)

		return -EPERM;

	retval = get_user(seqno, (__u64 __user *)arg);

	if (retval < 0)

		return retval;

	retval = copy_from_user(&seqno, (__u64 __user *)arg, sizeof(seqno));

	if (retval)

		return -EFAULT;

	retval = 0;

	if (seqno == 0) {

		list_for_each_entry_reverse(task, &stream->runtime->tasks, list)