Commit 60255f37 authored by Niravkumar L Rabara's avatar Niravkumar L Rabara Committed by Miquel Raynal
Browse files

mtd: rawnand: cadence: fix unchecked dereference 



Add NULL check before variable dereference to fix static checker warning.

Fixes: d76d22b5 ("mtd: rawnand: cadence: use dma_map_resource for sdma address")
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/e448a22c-bada-448d-9167-7af71305130d@stanley.mountain/


Signed-off-by: default avatarNiravkumar L Rabara <niravkumar.l.rabara@intel.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
parent 41758630

drivers/mtd/nand/raw/cadence-nand-controller.c

+4 −2
Original line number Diff line number Diff line
@@ -2972,8 +2972,10 @@ static int cadence_nand_init(struct cdns_nand_ctrl *cdns_ctrl) 
static void cadence_nand_remove(struct cdns_nand_ctrl *cdns_ctrl)

{

	cadence_nand_chips_cleanup(cdns_ctrl);

	dma_unmap_resource(cdns_ctrl->dmac->device->dev, cdns_ctrl->io.iova_dma,

			   cdns_ctrl->io.size, DMA_BIDIRECTIONAL, 0);

	if (cdns_ctrl->dmac)

		dma_unmap_resource(cdns_ctrl->dmac->device->dev,

				   cdns_ctrl->io.iova_dma, cdns_ctrl->io.size,

				   DMA_BIDIRECTIONAL, 0);

	cadence_nand_irq_cleanup(cdns_ctrl->irq, cdns_ctrl);

	kfree(cdns_ctrl->buf);

	dma_free_coherent(cdns_ctrl->dev, sizeof(struct cadence_nand_cdma_desc),