Commit 608446c2 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jiri Kosina
Browse files

HID: lenovo: silence unreachable code warning 



In theory, this code used to return 0 if CONFIG_ACPI_PLATFORM_PROFILE was
disabled.  It's not clear if that was a config which would actually boot
so we've removed the CONFIG_ACPI_PLATFORM_PROFILE ifdef.  But now the
"return 0;" statement is unreachable and static checker tools complain.

Delete it and pull the else statement in a tab to silence the checker
warning and make the code a bit more clear.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent d6ea85f8

drivers/hid/hid-lenovo.c

+2 −4
Original line number Diff line number Diff line
@@ -728,11 +728,9 @@ static int lenovo_raw_event_TP_X12_tab(struct hid_device *hdev, u32 raw_data) 
			if (hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB) {

				report_key_event(input, KEY_RFKILL);

				return 1;

			} else {

			}

			platform_profile_cycle();

			return 1;

			}

			return 0;

		case TP_X12_RAW_HOTKEY_FN_F10:

			/* TAB1 has PICKUP Phone and TAB2 use Snipping tool*/

			(hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB) ?