Commit 608662dd authored by Bastien Curutchet's avatar Bastien Curutchet Committed by Greg Kroah-Hartman
Browse files

usb: musb: da8xx: Remove try_idle implementation from host-only mode 



The idle_state is not meant for host-only mode. When the device acts as a
host, it fails to exit the idle state once entered. This prevents new
USB gadgets from being detected once plugged in.

Commit 032ec49f ("usb: musb: drop useless board_mode usage") removed
a is_otg_enabled() check in the try_idle() that prevented from entering
idle_state. This was removed because at that time it was not possible to
select host-only mode with CONFIG_USB_MUSB_HOST so dual role was always
set.

Add #ifndef CONFIG_USB_MUSB_HOST around try_idle() callback to prevent
from entering idle_state when host-only mode has been selected.

Signed-off-by: default avatarBastien Curutchet <bastien.curutchet@bootlin.com>
Link: https://lore.kernel.org/r/20240528102026.40136-4-bastien.curutchet@bootlin.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6ecd7749

drivers/usb/musb/da8xx.c

+4 −1
Original line number Diff line number Diff line
@@ -191,7 +191,7 @@ static void otg_timer(struct timer_list *t) 
	spin_unlock_irqrestore(&musb->lock, flags);

}



static void da8xx_musb_try_idle(struct musb *musb, unsigned long timeout)

static void __maybe_unused da8xx_musb_try_idle(struct musb *musb, unsigned long timeout)

{

	static unsigned long last_timer;
@@ -476,7 +476,10 @@ static const struct musb_platform_ops da8xx_ops = { 
	.disable	= da8xx_musb_disable,



	.set_mode	= da8xx_musb_set_mode,



#ifndef CONFIG_USB_MUSB_HOST

	.try_idle	= da8xx_musb_try_idle,

#endif



	.set_vbus	= da8xx_musb_set_vbus,

};