Commit 6090e612 authored by Ian Rogers's avatar Ian Rogers Committed by Namhyung Kim
Browse files

perf build python: Don't leave a.out file when building with clang 



Testing clang features doesn't specify a "-o" option so an a.out file
is created and left in the make directory (not the output). Fix this
by specifying a "-o" of "/dev/null". Reorganize the code a little to
help with readability.

Signed-off-by: default avatarIan Rogers <irogers@google.com>
Tested-by: default avatarJustin Stitt <justinstitt@google.com>
Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
parent 12690401

tools/perf/util/setup.py

+10 −3
Original line number Diff line number Diff line
@@ -23,10 +23,17 @@ assert srctree, "Environment variable srctree, for the Linux sources, not set" 
src_feature_tests  = f'{srctree}/tools/build/feature'



def clang_has_option(option):

    cmd = shlex.split(f"{cc} {cc_options} {option}")

    cmd.append(path.join(src_feature_tests, "test-hello.c"))

    error_substrings = (

        b"unknown argument",

        b"is not supported",

        b"unknown warning option"

    )

    cmd = shlex.split(f"{cc} {cc_options} {option}") + [

        "-o", "/dev/null",

        path.join(src_feature_tests, "test-hello.c")

    ]

    cc_output = Popen(cmd, stderr=PIPE).stderr.readlines()

    return [o for o in cc_output if ((b"unknown argument" in o) or (b"is not supported" in o) or (b"unknown warning option" in o))] == [ ]

    return not any(any(error in line for error in error_substrings) for line in cc_output)



if cc_is_clang:

    from sysconfig import get_config_vars