Commit 60ad1de8 authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Keith Busch
Browse files

nvmet-auth: update sc_c in host response 



The target code should set the sc_c bit in calculating the host response
based on the status of the 'concat' setting, otherwise we'll get an
authentication mismatch for hosts setting that bit correctly.

Fixes: 7e091add ("nvme-auth: update sc_c in host response")
Signed-off-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent 4c8cf6bd

drivers/nvme/target/auth.c

+3 −2
Original line number Diff line number Diff line
@@ -298,7 +298,7 @@ int nvmet_auth_host_hash(struct nvmet_req *req, u8 *response, 
	const char *hash_name;

	u8 *challenge = req->sq->dhchap_c1;

	struct nvme_dhchap_key *transformed_key;

	u8 buf[4];

	u8 buf[4], sc_c = ctrl->concat ? 1 : 0;

	int ret;



	hash_name = nvme_auth_hmac_name(ctrl->shash_id);
@@ -367,13 +367,14 @@ int nvmet_auth_host_hash(struct nvmet_req *req, u8 *response, 
	ret = crypto_shash_update(shash, buf, 2);

	if (ret)

		goto out;

	memset(buf, 0, 4);

	*buf = sc_c;

	ret = crypto_shash_update(shash, buf, 1);

	if (ret)

		goto out;

	ret = crypto_shash_update(shash, "HostHost", 8);

	if (ret)

		goto out;

	memset(buf, 0, 4);

	ret = crypto_shash_update(shash, ctrl->hostnqn, strlen(ctrl->hostnqn));

	if (ret)

		goto out;