Commit 60b5fd3f authored by Ian Rogers's avatar Ian Rogers Committed by Arnaldo Carvalho de Melo
Browse files

perf timechart: Use perf_tool__init() 



Use perf_tool__init() so that more uses of 'struct perf_tool' can be const
and not relying on perf_tool__fill_defaults().

Signed-off-by: default avatarIan Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: Ilkka Koskinen <ilkka@os.amperecomputing.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.g.garry@oracle.com>
Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Leo Yan <leo.yan@linux.dev>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Nick Terrell <terrelln@fb.com>
Cc: Oliver Upton <oliver.upton@linux.dev>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Song Liu <song@kernel.org>
Cc: Sun Haiyong <sunhaiyong@loongson.cn>
Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Yanteng Si <siyanteng@loongson.cn>
Cc: Yicong Yang <yangyicong@hisilicon.com>
Cc: linux-arm-kernel@lists.infradead.org
Link: https://lore.kernel.org/r/20240812204720.631678-21-irogers@google.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 4a20562b

tools/perf/builtin-timechart.c

+8 −9
Original line number Diff line number Diff line
@@ -1606,10 +1606,16 @@ static int __cmd_timechart(struct timechart *tchart, const char *output_name) 
		.mode  = PERF_DATA_MODE_READ,

		.force = tchart->force,

	};



	struct perf_session *session = perf_session__new(&data, &tchart->tool);

	struct perf_session *session;

	int ret = -EINVAL;



	perf_tool__init(&tchart->tool, /*ordered_events=*/true);

	tchart->tool.comm		 = process_comm_event;

	tchart->tool.fork		 = process_fork_event;

	tchart->tool.exit		 = process_exit_event;

	tchart->tool.sample		 = process_sample_event;



	session = perf_session__new(&data, &tchart->tool);

	if (IS_ERR(session))

		return PTR_ERR(session);
@@ -1924,13 +1930,6 @@ parse_time(const struct option *opt, const char *arg, int __maybe_unused unset) 
int cmd_timechart(int argc, const char **argv)

{

	struct timechart tchart = {

		.tool = {

			.comm		 = process_comm_event,

			.fork		 = process_fork_event,

			.exit		 = process_exit_event,

			.sample		 = process_sample_event,

			.ordered_events	 = true,

		},

		.proc_num = 15,

		.min_time = NSEC_PER_MSEC,

		.merge_dist = 1000,