Commit 61456da0 authored by Anthony I Gilea's avatar Anthony I Gilea Committed by Takashi Iwai
Browse files

ALSA: hda/realtek: Add quirk for HP Spectre x360 14 eu0000 



Cirrus amps support for this laptop was added in patch:
33e5e648 ("ALSA: hda: cs35l41: Support additional HP Envy Models")

This patch adds fixes for wrong pincfgs, wrong DAC selection and
mute/micmute LEDs.

Signed-off-by: default avatarAnthony I Gilea <i@cpp.in>
Message-ID: <e2a7aaed-e9d7-4d36-8abf-b71dfd32a0ff@cpp.in>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 1e5dc398

sound/pci/hda/patch_realtek.c

+38 −1
Original line number Diff line number Diff line
@@ -7123,6 +7123,38 @@ static void alc_fixup_headset_mic(struct hda_codec *codec, 
	}

}



static void alc245_fixup_hp_spectre_x360_eu0xxx(struct hda_codec *codec,

					  const struct hda_fixup *fix, int action)

{

	/*

	 * The Pin Complex 0x14 for the treble speakers is wrongly reported as

	 * unconnected.

	 * The Pin Complex 0x17 for the bass speakers has the lowest association

	 * and sequence values so shift it up a bit to squeeze 0x14 in.

	 */

	static const struct hda_pintbl pincfgs[] = {

		{ 0x14, 0x90170110 }, // top/treble

		{ 0x17, 0x90170111 }, // bottom/bass

		{ }

	};



	/*

	 * Force DAC 0x02 for the bass speakers 0x17.

	 */

	static const hda_nid_t conn[] = { 0x02 };



	switch (action) {

	case HDA_FIXUP_ACT_PRE_PROBE:

		snd_hda_apply_pincfgs(codec, pincfgs);

		snd_hda_override_conn_list(codec, 0x17, ARRAY_SIZE(conn), conn);

		break;

	}



	cs35l41_fixup_i2c_two(codec, fix, action);

	alc245_fixup_hp_mute_led_coefbit(codec, fix, action);

	alc245_fixup_hp_gpio_led(codec, fix, action);

}





enum {

	ALC269_FIXUP_GPIO2,
@@ -7402,6 +7434,7 @@ enum { 
	ALC245_FIXUP_CS35L56_SPI_4_HP_GPIO_LED,

	ALC256_FIXUP_ACER_SFG16_MICMUTE_LED,

	ALC256_FIXUP_HEADPHONE_AMP_VOL,

	ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX,

};



/* A special fixup for Lenovo C940 and Yoga Duet 7;
@@ -9605,6 +9638,10 @@ static const struct hda_fixup alc269_fixups[] = { 
		.type = HDA_FIXUP_FUNC,

		.v.func = alc256_decrease_headphone_amp_val,

	},

	[ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX] = {

		.type = HDA_FIXUP_FUNC,

		.v.func = alc245_fixup_hp_spectre_x360_eu0xxx,

	},

};



static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -9968,7 +10005,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { 
	SND_PCI_QUIRK(0x103c, 0x8be8, "HP Envy 17", ALC287_FIXUP_CS35L41_I2C_2),

	SND_PCI_QUIRK(0x103c, 0x8be9, "HP Envy 15", ALC287_FIXUP_CS35L41_I2C_2),

	SND_PCI_QUIRK(0x103c, 0x8bf0, "HP", ALC236_FIXUP_HP_GPIO_LED),

	SND_PCI_QUIRK(0x103c, 0x8c15, "HP Spectre 14", ALC287_FIXUP_CS35L41_I2C_2),

	SND_PCI_QUIRK(0x103c, 0x8c15, "HP Spectre x360 2-in-1 Laptop 14-eu0xxx", ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX),

	SND_PCI_QUIRK(0x103c, 0x8c16, "HP Spectre 16", ALC287_FIXUP_CS35L41_I2C_2),

	SND_PCI_QUIRK(0x103c, 0x8c17, "HP Spectre 16", ALC287_FIXUP_CS35L41_I2C_2),

	SND_PCI_QUIRK(0x103c, 0x8c46, "HP EliteBook 830 G11", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),