Commit 61753849 authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski
Browse files

net-sysfs: remove rcu field from 'struct rps_sock_flow_table' 



Removing rcu_head (and @mask in a following patch)
will allow a power-of-two allocation and thus high-order
allocation for better performance.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20260302181432.1836150-3-edumazet@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 42a10177

include/net/rps.h

+0 −1
Original line number Diff line number Diff line
@@ -60,7 +60,6 @@ struct rps_dev_flow_table { 
 * meaning we use 32-6=26 bits for the hash.

 */

struct rps_sock_flow_table {

	struct rcu_head	rcu;

	u32		mask;



	u32		ents[] ____cacheline_aligned_in_smp;

net/core/sysctl_net_core.c

+3 −1
Original line number Diff line number Diff line
@@ -147,6 +147,7 @@ static int rps_sock_flow_sysctl(const struct ctl_table *table, int write, 
	};

	struct rps_sock_flow_table *orig_sock_table, *sock_table;

	static DEFINE_MUTEX(sock_flow_mutex);

	void *tofree = NULL;



	mutex_lock(&sock_flow_mutex);
@@ -193,13 +194,14 @@ static int rps_sock_flow_sysctl(const struct ctl_table *table, int write, 
			if (orig_sock_table) {

				static_branch_dec(&rps_needed);

				static_branch_dec(&rfs_needed);

				kvfree_rcu(orig_sock_table, rcu);

				tofree = orig_sock_table;

			}

		}

	}



	mutex_unlock(&sock_flow_mutex);



	kvfree_rcu_mightsleep(tofree);

	return ret;

}

#endif /* CONFIG_RPS */