Unverified Commit 61d2a769 authored by Charles Keepax's avatar Charles Keepax Committed by Mark Brown
Browse files

ASoC: SDCA: Tidy up some memory allocations 



It is slightly better to deference the type being allocate for a sizeof
rather than manually using the type. Saves effort if types change in the
future. This results in no functional changes, just tidies up the style
of the code a little.

Signed-off-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20260115114607.271990-1-ckeepax@opensource.cirrus.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 57aa7735

sound/soc/sdca/sdca_fdl.c

+1 −1
Original line number Diff line number Diff line
@@ -487,7 +487,7 @@ int sdca_fdl_alloc_state(struct sdca_interrupt *interrupt) 
	struct device *dev = interrupt->dev;

	struct fdl_state *fdl_state;



	fdl_state = devm_kzalloc(dev, sizeof(struct fdl_state), GFP_KERNEL);

	fdl_state = devm_kzalloc(dev, sizeof(*fdl_state), GFP_KERNEL);

	if (!fdl_state)

		return -ENOMEM;

sound/soc/sdca/sdca_functions.c

+3 −3
Original line number Diff line number Diff line
@@ -952,7 +952,7 @@ static int find_sdca_entity_control(struct device *dev, struct sdca_entity *enti 
	}



	control->values = devm_kcalloc(dev, hweight64(control->cn_list),

				       sizeof(int), GFP_KERNEL);

				       sizeof(*control->values), GFP_KERNEL);

	if (!control->values)

		return -ENOMEM;
@@ -2048,7 +2048,7 @@ static int find_sdca_filesets(struct device *dev, struct sdw_slave *sdw, 
	fwnode_property_read_u32_array(function_node, "mipi-sdca-file-set-id-list",

				       filesets_list, num_sets);



	sets = devm_kcalloc(dev, num_sets, sizeof(struct sdca_fdl_set), GFP_KERNEL);

	sets = devm_kcalloc(dev, num_sets, sizeof(*sets), GFP_KERNEL);

	if (!sets)

		return -ENOMEM;
@@ -2074,7 +2074,7 @@ static int find_sdca_filesets(struct device *dev, struct sdw_slave *sdw, 
		dev_dbg(dev, "fileset: %#x\n", filesets_list[i]);



		files = devm_kcalloc(dev, num_entries / mult_fileset,

				     sizeof(struct sdca_fdl_file), GFP_KERNEL);

				     sizeof(*files), GFP_KERNEL);

		if (!files)

			return -ENOMEM;