Commit 61e1d394 authored by Srikar Dronamraju's avatar Srikar Dronamraju Committed by Oleg Nesterov
Browse files

uprobes: Remove redundant lock_page/unlock_page 



Since read_opcode() reads from the referenced page and doesnt modify
the page contents nor the page attributes, there is no need to lock
the page.

Signed-off-by: default avatarSrikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
parent 508dc4f8

kernel/events/uprobes.c

+0 −2
Original line number Diff line number Diff line
@@ -280,12 +280,10 @@ static int read_opcode(struct mm_struct *mm, unsigned long vaddr, uprobe_opcode_ 
	if (ret <= 0)

		return ret;



	lock_page(page);

	vaddr_new = kmap_atomic(page);

	vaddr &= ~PAGE_MASK;

	memcpy(opcode, vaddr_new + vaddr, UPROBE_SWBP_INSN_SIZE);

	kunmap_atomic(vaddr_new);

	unlock_page(page);



	put_page(page);